Thank you for catching it! I forgot to restore "return null;".
Masayoshi
On 7/23/2014 3:44 AM, Naoto Sato wrote:
Okutsu-san,
I have one question. It looks like if the user specifies the
additional era syntactically incorrect, it throws a RuntimeException.
Should it just be ignored, as the spec reads "If the given era is
invalid, such as the since value before the beginning of the last
predefined era, the given era will be ignored"?
Naoto
On 7/22/14, 12:06 AM, Masayoshi Okutsu wrote:
Hello,
Please review the change for JDK-8048123. This change removes all the
era definitions in ${java.home}/lib/calendars.properties. (The property
file will eventually be gone later.) The major change is that any new
era of the Japanese calendar should now be defined using new property
"jdk.calendar.japanese.supplemental.era".
https://bugs.openjdk.java.net/browse/JDK-8048123
Webrev includes some unrelated cleanups.
http://cr.openjdk.java.net/~okutsu/9/8048123/webrev.00/
Thanks,
Masayoshi
