Yuri,
that java code is normally auto generated with the
src/solaris/classes/sun/awt/X11/genhash.awk file :
# With this script one can generate a new version XKeysym.java file out
# of keysym2ucs.h prototype and UnicodeData.txt database.
# Latter file should be fetched from a unicode.org site, most
# probably http://www.unicode.org/Public/UNIDATA/UnicodeData.txt
Since the same approach (manual update) was taken for jdk8 fix, I
suspect it should work for 7u also.
Frank - can you address Yuri's question? Let's wait for confirmation
from Yuri also on whether he's ok with this port and if there are no
objections, Iet's consider this approved for jdk7u-dev. Please provide a
testcase if possible. I'm also assuming that you'll verify the fix in a
Japanese locale before pushing.
regards,
Sean.
On 31/01/2013 07:02, Yuri Nesterenko wrote:
Colleagues,
I'm someway out of sync here but how about the first line in
XKeysym.java?
1 // This is a generated file: do not edit! Edit keysym2ucs.h if
necessary.
Either this rather unusual approach should be changed or
keysym2ucs.h prototype changed first.
Thanks,
-yan
On 01/31/2013 06:08 AM, Frank Ding wrote:
Hi Naoto,
Thank you.
To Sean,
Could you please shed your light or anything I can do?
Best regards,
Frank
On 1/31/2013 3:15 AM, Naoto Sato wrote:
OK, I am fine with backporting the fix. Please go ahead.
Naoto
On 1/29/13 9:34 PM, Frank Ding wrote:
Hi Naoto and Sean
I think we can verify it in Japanese environment.
The reason for backporting is that it's quite safe to do and also
would be better if the defect is fixed in JDK 7 also. Please let me
know if there is any idea. Thank you.
Best regards,
Frank
While I think fix looks good (that's why I approved the change in
jdk8),
I don't find any reason for backporting this change into 7u line. Is
there any strong reason for backport?
Naoto
On 9/18/12 10:37 AM, Seán Coffey wrote:
> cc'ing i18n-dev alias here also. i18n fixes can be difficult to
test.
> Was it possible to verify this fix on jdk7u Shi Jun ?
>
> Any thoughts from i18n reviewers on this one being backported to
7u ?
>
> regards,
> Sean.
>
> On 17/09/2012 08:07, Shi Jun Zhang wrote:
>> Hi all,
>>
>> I'd like to request for approval to push the following change into
7u10.
>>
>> Changeset in jdk8
>>http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6694d9e99716
>>
>> Webrev
>>http://cr.openjdk.java.net/~zhangshj/jdk7u/7174233/webrev.00/
>>
>> Reviewed by anthony, naoto
>>
>> Review thread
>>http://mail.openjdk.java.net/pipermail/awt-dev/2012-June/002919.html
>>
>
