Hi Thomas, I agree with all your comments. I try to respect white space formatting/indenting conventions but must have missed something. Some of the whitespace I added was simply to eliminate gcc warnings.
If you haven't used meld for comparing source code directories (and code changes file by file), I recommend you give it a try. It's magic: http://meldmerge.org/ I have used it to compare projects as big as darktable. Bruno & Thomas -- I think I'd just release rc2 as is. Looks good to me. Cheers, Jeff On Thu, Sep 7, 2023 at 8:22 AM T. Modes <[email protected]> wrote: > I will look at the changes. > But that you put all changes into one big patch makes is difficult to test > or comment on single issues. > But some comments: > * you are fixing the warning for a specific version of a specific > compiler. Other compiles or even other versions the same compiler will > throw warnings on different issues. So fixing all warnings for all > compilers and all it version (especially for a platform independent way) is > a lot of work with only little benefits. > * Your changes break the ABI again, this is something which we would > prevent in this release. > * You did also white spaces changes and introduced a mixed indentation > style. > > Thomas > > -- > A list of frequently asked questions is available at: > http://wiki.panotools.org/Hugin_FAQ > --- > You received this message because you are subscribed to the Google Groups > "hugin and other free panoramic software" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/hugin-ptx/7b149cca-a00a-49c4-aa1f-b139d4be7630n%40googlegroups.com > <https://groups.google.com/d/msgid/hugin-ptx/7b149cca-a00a-49c4-aa1f-b139d4be7630n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ --- You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/hugin-ptx/CAPc%2BVuKB1uPWFqU0Qe3k5_3yDic%2BL9xEWeU4dDD69mh%2B61gWWg%40mail.gmail.com.
