Thanks Jeff, these look good to me but I'll defer to Thomas. Unless anyone has any objections, I'll release rc2 as libpano-2.9.22.
-- Bruno On Wed, 16 Aug 2023 at 18:29, Jeff Welty wrote: > I didn't see any tags for rc2 in mercurial, so I made this patch which > gives changes I made against rc2 -- which I think will allow you better see > the incremental changes I made. > I am using gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0 > --- > Changes of note: > - I added more warnings for UNIX in CMakeLists.txt, you may or may not > want to leave those in, or put them in a more appropriate place in the file. > - bmp.c -- I made some minor structural changes to handle the case where > height in the bmp header is negative and not properly handled by the > unsigned integers. I didn't test it on a bmp image file. > - PTcommon.c -- here the call to nextWord at about line 874 was throwing a > warning, to eliminate the warning I chose to pass a flag to the nextWord > function itself in parser.c It seems like overkill to me to eliminate the > warning, but I didn't want to change the basic nextWord function in other > ways. Personally I think I'd keep the original nextWord logic and just > live with the warning, knowing there is no logical bug. If that's what you > would like let me know and I'll restore it. > > Other than that it's mostly initializing some variables, handling a few > signed/unsigned conflicts, and simple reformatting of "if" statements to > keep the compiler happy and make the code a bit more intuitive as you see > it displayed. > > I like to use #ifdef's to "comment out" large blocks of code that may have > a use in the future. You might prefer to just delete those sections of > code... > > Hope this is helpful, > -- A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ --- You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/hugin-ptx/CAJV99ZjJgXPdAFVhiFaACd9Td%3D9fc0eRx5twcigevBYvH10GEg%40mail.gmail.com.
