2015-02-25 16:47 GMT+01:00 Hardy Ferentschik <ha...@hibernate.org>: > > > A dedicated module means less surprises and less understanding needed > to > > > see how > > > things get together. > > > > > > > Hm, but test JARs have been an exception to that "rule" in Maven for a > long > > time. So no-one should really be surprised by using that concept. > > Hmm, not sure. > > > > Also, having a dedicated module allows for adding an additional README > > > which for > > > example described the purpose of these tests, how they are executed and > > > that they > > > are used by each dialect. > > > > > > > Would it help if we add a note to the main readme.md, or maybe > > package-info.java in the TCK package? Personally I prefer to have all > > build-related info in one readme rather than scattered over several > places. > > But that's partly my point. Your solutions require me to read something, > whereas a dedicated module is almost self explaining. > > > It's not that I'm not against that move per se, I only have doubts > whether > > there is much benefit to it. > > IMO yes > > > My main concern still is whether that move would complicate running tests > > in core itself? Today I can click and run the TCK tests in core in the > IDE > > without any further preparation. If that'd get more difficult, I'd vote > > against that split. > > Well, with the helper I am suggesting it is still a single click :-) >
So I can click a single test and run it in core without further ado? If so, it's cool. Also for the actual backend modules. But I understood I'd have to adapt that helper to tell which test to run? That's what I'd like to avoid, at least in core. --Hardy > > _______________________________________________ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
