On 1/28/2011 12:51 PM, Eystein Måløy Stenberg wrote:
> Interesting. Are any of you using commit hooks for peer review? I.e.
> "don't allow a change to go to repository unless it has been approved by
> 5 people"?
>
> It seems like to implement this, you would need to initially submit your
> "RFCs" (policy changes) to a different system (like Trac, I guess), and
> then have that system commit to svn as soon as it has been approved?
>
> If you use svn directly, either the repository would get "contaminated"
> by unapproved changes (posting to Trac in post-commit), or nobody would
> be able to commit (pre-commit doesn't work because the script would need
> to wait for 5 people before finishing the commit?).
>
> Perhaps using multiple repositories would help?
>
> It would be very interesting to hear if any of you have smart solutions
> to this peer review problem.
If you need a workflow like that you probably want to restrict direct
commit access to the 'approved' branch and have an authorized person do
the merges to it. There's nothing inherently wrong with having things
pending approval in a version control repository - in fact that's pretty
much what they are for.
--
Les Mikesell
lesmikes...@gmail.com
_______________________________________________
Help-cfengine mailing list
Help-cfengine@cfengine.org
https://cfengine.org/mailman/listinfo/help-cfengine
