On Mon, 29 Mar 2010, Szak�ts Viktor wrote:
Hi,
> Keyboard handling uses some strange xhb
> method which don't seem to be present in
> Harbour, but the rest is pretty mechanical
> bugfixing and applying usual cleaning/fixing
> steps we used to have in Harbour-quality code.
> The code is quite large so it needs time if
> someone wants to take the job seriously.
I'm afraid it's not such simple.
This code either in Harbour or xHarbour ports has
bugs which have to be fixed to make it production
ready. In most of cases these are the same errors
in both projects because the code in Harbour SVN is
in practice the same as in xHarbour CVS and Viktor
only updated it to compile cleanly with Harbour API
and cleaned some small part of this code removing
redundant constructions.
But it does not mean that it will work correctly with
Harbour or that it works correctly with xHarbour.
In both cases it's broken, i.e. things like s_iCursorStyle
cannot work properly when more then one window is created.
Many methods should not be overloaded at at all (in general
this code does not try to benefit from new GT API at all.
Ne GT API allows to greatly simplify it and probably remove
about 50% of the core WVW code.
Some things in this library looks like copy and past from
different project and the author didn't understand what
exactly the code he collected does, i.e.
TEXT( (char*) hb_parvcx( 1,11 ) )
is complete technical nonsense and this probably causes
that non of use wants to touch it at all because to change
sth it's necessary to check each line which can be broken
and it's a to big risk that one fix will exploit new bugs.
IMO it's much easier to write new GT driver with similar
functionality from scratch then start updating this code
which in current state it's not production ready. It doesn't
matter you are using Harbour or xHarbour.
best regards,
Przemek
_______________________________________________
Harbour mailing list (attachment size limit: 40KB)
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour
