Hi Pritpal, >> Anyhow it would be important to remove the >> palette incompatibility. Leaving incompatibility >> for all Harbour user base, just because there >> is some local code, which you cannot modify >> is not a very good solution for Harbour IMO. >> > > I had to dig deep to gather facts about it. > > Here is the changelog entries: >> Consistency should always have priority over >> local/personal reasons IMO. And the more we >> delay it, the worse it gets. >> > > Tell me who broke the consistancy ?
You introduced a feature in SVN which used completely inconsistent numbering, using 1 for black, which is historically zero. Then someone (not me BTW) pointed out this error, and we corrected it, except GTWVG, which is now inconsistent. > There is no concept of 0 base in Clipper code, is there ? There is. > When I implemented it as HB_GTI_PALETTE call, I took > PRG code in perspective, to keep it consistent with > array assign/retreival. so that user could assign/retieve > either the whole palette or single color with one directive. > > For example > > #define COLOR_BLUE 2 > > aRGB := hb_gtInfo( HB_GTI_PALETTE ) > aRGB[ COLOR_BLUE ] := nRGB > hb_gtInfo( HB_GTI_PALETTE, aRGB ) > > OR > > hb_gtInfo( HB_GTI_PALETTE, COLOR_BLUE, nRGB ) > > I presume, I was right when I introduced it first. > How it went the other way, I am still at a loss. Try HB_DISPOUTAT(). Or most other past tools that referred to 16 supported colors with numerical value, or foreground/background color combination as an 8-bit value, they all used and uses 0x00 - 0x0F indexes to refer to colors. I'm really not willing to open a long debate this time, we made a decision and for the sake of all Harbour users, you will just have to adapt your local codebase. Many of us have done this many times in the history of Harbour so there is nothing special in this practice, especially with features not yet matured. Our priority is simply to do the best for Harbour, not to save some personal time for a few users or one user. (you wouldn't believe how many days I've spent adapting my code to Harbour GT engine changes alone in the last 11 years, and the palette one doesn't look like a particularly complicated and time-consuming change to make). Pls adapt. Brgds, Viktor _______________________________________________ Harbour mailing list (attachment size limit: 40KB) Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
