Xavi, On 2009 Dec 16, at 15:01, Xavi wrote:
> Sorry Viktor, > >> bad formatting. > > Not is a bad format, it's just that you don't like, since 25 years I've been > writing C in this format as I learned reading "the > bible of C" (The C Programming Language by Brian W. Kernighan and Dennis M. > Ritchie) I'm too old to change. For example, code > from the same author .- I don't care the least what others use. We're using one consistent style in Harbour, in about 13MBs of .c source code contributed by 100 different authors. The point of using consistent style in _any_ project is to help maintainers and other contributors to catch up with code and not to be slowed down by trying to understand the personal style of each contributor. Just imagine for a second what would happen if each patch would use a different style. Or look at xhb code. It's BTW not what _I_ like, it's what we've settled upon in the last 10 years, it's not even close the style I used throughout this time (although by now I've adapted it in local project, but that's irrelevant), and it was not me who invented it. It was largely introduced by Antonio in the beginning, but that's also irrelevant. > http://cm.bell-labs.com/cm/cs/tpop/markov.c Irrelevant and also wrong for Harbour. Pls read doc/codestyl.txt, which specifically tells _not_ to use the K&R style. If you had ever looked into any .c files in Harbour, you'll find out that we don't use it. > I adapt the format if I correct code from another author, but in my code > should require the same. > Please don't change the format to spd.c, sql_Sprintf(). I can't promise that. The only reason I didn't touch that code, is because you're the only one maintaining it. For hbwin and 98% of Harbour code, this probably won't be true and can't be true, so you'll have to stick with Harbour standards. > I very much regret your decision and to subtract instead of adding in the > Harbour project. Subtract? Don't make me laugh, or you must be blind... Such insult is BTW pretty sad to see given the amount of work I put into this, and remember I'm not getting a paycheck, so rather enjoy you get something for free. (this also applies to other contributors of course.) Brgds, Viktor _______________________________________________ Harbour mailing list (attachment size limit: 40KB) Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
