Hi, Thank you, sorry to insist but I'd like to ask you to fix formatting. For me it's a terrible waste of time to fix all such code to have common format which we use in all our files. There was a lot of energy put in that, and as in all serious projects also in Harbour its important to keep it that way to easy contributors job when reviewing and working with the code in future updates, grep work, copy/paste and keeping a common layout for all files belonging to this project. F.e. pls compare tprinter.prg from xhb and win_prn*.c in Harbour to see the difference.
Or if not, I hope someone else will commit it, hopefully also fixing this issue, but I only have 24 hours a day and there several are more exciting and more important things to do than fixing other ppl's code endlessly. This isn't a personal thing, it goes to every contributor. Brdgs, Viktor On 2009 Dec 16, at 03:47, Xavi wrote: > Viktor, > > Ok, adapted as WAPI_ and WinCE .- > > Windows CE 1.01 and later > Windows Mobile Version 5.0 and later > > http://msdn.microsoft.com/en-us/library/aa914601.aspx > > Running.prg .- > > static s_hMutex > > Procedure Main() > Local cAppName > > // It may be a random program name :) > hb_FNameSplit( hb_ProgName(), nil, @cAppName ) > > s_hMutex := wapi_CreateMutex( nil, nil, cAppName ) > if !Empty( s_hMutex ) .and. (wapi_GetLastError() == 0) > ? cAppName, "=> Hello World! OK." > else > ? cAppName, "=> Application is running. Error", wapi_GetLastError() > endif > > Wait > return > > Source contrib/hbwin > > -- > Xavi > > Viktor Szakáts escribió: >> Hi Xavi, >> This seems pretty sensitive area of Windows, so it will need testing on all >> compilers and especially on WinCE. I'm not sure we should add it right now >> as it may delay the release. [ apparently some of us are already doing build >> tests since today ] >> In the meantime, I'd like to ask you to reformat it as per Harbour standards >> (spaces and {} usage) and fix windows header inclusion to use >> HB_OS_WIN_USED. Please change function name prefix to WAPI_ (from WIN_) >> since these are perfect mirrors of WinAPI functions. >> Otherwise it looks good and even UNICODE ready. Thank you. >> Brgds, >> Viktor > > > > > /* > * Harbour Project source code: > * Windows Mutex functions > * > * Copyright 2009 Xavi <jarabal/at/gmail.com> > * > * This program is free software; you can redistribute it and/or modify > * it under the terms of the GNU General Public License as published by > * the Free Software Foundation; either version 2, or (at your option) > * any later version. > * > * This program is distributed in the hope that it will be useful, > * but WITHOUT ANY WARRANTY; without even the implied warranty of > * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > * along with this software; see the file COPYING. If not, write to > * the Free Software Foundation, Inc., 59 Temple Place, Suite 330, > * Boston, MA 02111-1307 USA (or visit the web site http://www.gnu.org/). > * > * As a special exception, the Harbour Project gives permission for > * additional uses of the text contained in its release of Harbour. > * > * The exception is that, if you link the Harbour libraries with other > * files to produce an executable, this does not by itself cause the > * resulting executable to be covered by the GNU General Public License. > * Your use of that executable is in no way restricted on account of > * linking the Harbour library code into it. > * > * This exception does not however invalidate any other reasons why > * the executable file might be covered by the GNU General Public License. > * > * This exception applies only to the code released by the Harbour > * Project under the name Harbour. If you copy code from other > * Harbour Project or Free Software Foundation releases into a copy of > * Harbour, as the General Public License permits, the exception does > * not apply to the code that you add in this way. To avoid misleading > * anyone as to the status of such modified files, you must delete > * this exception notice from them. > * > * If you write modifications of your own for Harbour, it is your choice > * whether to permit this exception to apply to your modifications. > * If you do not wish that, delete this exception notice. > * > */ > > #define HB_OS_WIN_USED > > #include "hbapi.h" > #include "hbwinuni.h" > > #include <winbase.h> > > static HB_GARBAGE_FUNC( wapi_mutex_release ) > { > void **ph = (void **)Cargo; > > if( ph && *ph ){ > CloseHandle( (HANDLE)*ph ); > *ph = NULL; > } > } > > static const HB_GC_FUNCS s_gc_wapi_mutex_funcs = > { > wapi_mutex_release, > hb_gcDummyMark > }; > > static void wapi_mutex_ret( HANDLE hMutex ) > { > if( hMutex ){ > void **ph = (void **)hb_gcAllocate( sizeof(HANDLE *), > &s_gc_wapi_mutex_funcs ); > > *ph = hMutex; > hb_retptrGC( ph ); > }else > hb_retptr( NULL ); > } > > static HANDLE wapi_mutex_par( int iParam ) > { > void **ph = (void **)hb_parptrGC( &s_gc_wapi_mutex_funcs, iParam ); > > return (ph ? (HANDLE)*ph : NULL); > } > > /* HANDLE WINAPI CreateMutex( LPSECURITY_ATTRIBUTES lpMutexAttributes, BOOL > bInitialOwner, LPCTSTR lpName ) */ > HB_FUNC( WAPI_CREATEMUTEX ) > { > void *hName; > HANDLE hMutex = CreateMutex( (LPSECURITY_ATTRIBUTES)hb_parptr( 1 ), > hb_parl( 2 ), HB_PARSTR( 3, &hName, NULL ) ); > > wapi_mutex_ret( hMutex ); > hb_strfree( hName ); > } > > /* HANDLE WINAPI OpenMutex( DWORD dwDesiredAccess, BOOL bInheritHandle, > LPCTSTR lpName ) */ > HB_FUNC( WAPI_OPENMUTEX ) > { > #if ! defined( HB_OS_WIN_CE ) > void *hName; > HANDLE hMutex = OpenMutex( hb_parnl( 1 ), hb_parl( 2 ), HB_PARSTR( 3, > &hName, NULL ) ); > > wapi_mutex_ret( hMutex ); > hb_strfree( hName ); > #else > hb_retptr( NULL ); > #endif > } > > /* BOOL WINAPI ReleaseMutex( HANDLE hMutex ) */ > HB_FUNC( WAPI_RELEASEMUTEX ) > { > HANDLE hMutex = wapi_mutex_par( 1 ); > > hb_retl( hMutex ? ReleaseMutex( hMutex ) : HB_FALSE ); > } > > # > # $Id: Makefile 13225 2009-12-12 14:43:52Z vszakats $ > # > > ROOT := ../../ > > include $(TOP)$(ROOT)config/global.mk > > LIBNAME := hbwin > > C_SOURCES := \ > mapi.c \ > olecore.c \ > oleinit.c \ > axcore.c \ > legacycd.c \ > legacyco.c \ > legacycp.c \ > legacycr.c \ > legacycv.c \ > wce_simc.c \ > wce_smsc.c \ > win_com.c \ > win_dll.c \ > win_misc.c \ > win_osc.c \ > win_prn1.c \ > win_prn2.c \ > win_prn3.c \ > win_regc.c \ > wapi_commctrl.c \ > wapi_shellapi.c \ > wapi_winbase.c \ > wapi_mutex.c \ > wapi_winuser.c \ > > PRG_SOURCES := \ > legacy.prg \ > oleauto.prg \ > axfunc.prg \ > wce_sim.prg \ > win_tcom.prg \ > win_os.prg \ > win_reg.prg \ > win_tprn.prg \ > > C_HEADERS := \ > hbwapi.h \ > hbwin.h \ > hbwinole.h \ > > PRG_HEADERS := \ > hbwin.ch \ > > ifneq ($(filter $(HB_PLATFORM),win wce),) > include $(TOP)$(ROOT)config/header.mk > include $(TOP)$(ROOT)config/lib.mk > else > HB_SKIP_REASON := platform not supported > include $(TOP)$(ROOT)config/none.mk > endif > <wapi_mutex.zip> _______________________________________________ Harbour mailing list (attachment size limit: 40KB) Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
