On Tue, 01 Dec 2009, Szak�ts Viktor wrote:

Hi,

> >> [ BTW it's not fully compatible, as C5.3 returned the old 
> >> dev mode value. ]
> > Yes, I know. I think we should change:
> >   BOOL hb_fsSetDevMode( HB_FHANDLE hFileHandle, USHORT uiDevMode )
> > to:
> >   int hb_fsSetDevMode( HB_FHANDLE hFileHandle, int iDevMode )
> > and also return previous value or -1 on error and then update FSETDEVMOD()
> > to work like in Clipper. I can make such modification.
> Thank you, it would very nice.

I've already made this modification then I also made some tests with
FSETDEVMOD() in C53 and before I'll commit it I have two questions:
1. CL53 returns only 1 or 2 and nothing more to indicate errors.
   Should I replicate it?
2. In tests it looks that it has some logic to return value for
   current file descriptor state if second parameter is not passed.
   In our source code we have:
      /* C53 checks only number of parameters: hb_pcount() == 2 */
      if( HB_ISNUM( 1 ) && HB_ISNUM( 2 ) )
      {
         ...
      }
   are you sure that the note and condition are valid?

best regards,
Przemek
_______________________________________________
Harbour mailing list (attachment size limit: 40KB)
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour

Reply via email to