On Mon, 30 Nov 2009, Mindaugas Kavaliauskas wrote:

Hi,

> Yes, perhaps type should be unsigned int. HRESULT is a "general"
> return value, since MS uses type casting anythere.

OK, I'll update it.

> >2009-11-28 13:27 UTC+0100 Przemyslaw Czerpak (druzus/at/priv.onet.pl)
> >  * harbour/contrib/hbwin/olecore.c     ! fixed typo in last
> >commit
> I guess it is only cosmetic change, because both punkVal and
> pdispVal are the two interfaces of the same object. I do not see the
> difference, though, this could be more nice form, because punkVal is
> contained inside VARIANT and will be freed on VariantClear() later.

I'm not very familiar with OLE code so maybe I'm wrong but I do not see
any reason why it has to be the same pointer. I can imagine implementation
which will use different pointers so I would like to keep the code clean
and if I called punkVal->QueryInterface() extracting pdispVal then I'd
prefer release it using:
   pdispVal->Release();
instead of:
   punkVal->Release();

BTW thank you very much for CAIRO wrapper.

best regards,
Przemek
_______________________________________________
Harbour mailing list (attachment size limit: 40KB)
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour

Reply via email to