+1

On 2008.10.02., at 16:00, Mindaugas Kavaliauskas wrote:

Przemyslaw Czerpak wrote:
2008-09-21 23:03 UTC+0200 Przemyslaw Czerpak (druzus/at/priv.onet.pl)
 ...
 * harbour/source/vm/thread.c
   + added support for inheriting visible memvars from current
     thread when new thread is created. Memvars in child thread
can be shared with parrent or they can be copied. See HB_THREAD_*
     attributes defined in hbthread.ch, f.e.:
        hb_threadStart( HB_THREAD_INHERIT_PUBLIC, @thFunc() )
     or:
        hb_threadStart( HB_BITOR( HB_THREAD_INHERIT_MEMVARS + ;
                                  HB_THREAD_MEMVARS_COPY ), ;
                         @thFunc() )


Hi,


I suggest to swap 1st and 2nd parameters. The main parameter of hb_threadStart() is code to be executed (in any form: block, symbol or function pointer), inheritance flags are only options. So, it is logic to put code parameter in the first place. Flags can have a default value, and if it default flags are OK, hb_threadStart(@func()) looks much better, than hb_threadStart(, @func()).


Best regards,
Mindaugas

_______________________________________________
Harbour mailing list
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour

_______________________________________________
Harbour mailing list
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour

Reply via email to