On Mon, 25 Aug 2008, Szakáts Viktor wrote:

Hi Viktor,

> Here's a somewhat fixed hbsetup.h + diff, what's your opinion?

It's OK for me but why we still have:
   #define OS_DOS_COMPATIBLE
instead of:
   #define HB_OS_DOS_COMPATIBLE
?

BTW HB_OS_UNIX_COMPATIBLE is for native *nix systems and
environments which try to emulate them, f.e. CYGWIN or
CEGCC (it's not MinGW-CE).
Probably we can remove it and use HB_OS_UNIX but first we
should clean CYGWIN builds. I've seen in change log:
   ; TOFIX: (for __CYGWIN__)
     ../../filesys.c: In function `hb_fsPOpen':
     ../../filesys.c:577: warning: passing arg 1 of `pipe' from incompatible 
pointer type

It means that in CYGWIN builds WIN32_IO is used and mixed with stdio.
It cannot work. CYGWIN port developers should decide what they want
to do. Use native windows API or POSIX one. If POSIX then all calls
to MS-Win functions should be excluded and it should use int for file
handles. In such case we can HB_OS_UNIX for this build and undef
HB_OS_WIN32. Otherwise I do not see big sense in keeping CYGWIN
builds as long as we have MinGW one.

best regards,
Przemek
_______________________________________________
Harbour mailing list
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour

Reply via email to