Re: [Harbour] 2008-08-09 11:43 UTC+0200 Viktor Szakats (harbour.01 syenar hu)

[Szakáts Viktor]

Hi Przemek,

Thank you, I cannot test it but it looks correct. I'll ad only minor
cleanup.

    ! Fixed generating links for .dylibs on Darwin.

This is incorrect. You replaced relative soft links with
absolute ones and should be reverted.

Okay, sorry, I'll undo this if you didn't do so in
your commit.

    ! Removed one excessive 'cd "${OTMPDIR}"' command.
      (I hope this is right)

It was minor protection against theoretically possible error in
mkdir/cd operations executed during .a files extracting.

Same as above.

    ! Removed previously added $(L_USR) from Darwin dynamic
      lib creation command line, as the L_USR "-arch" flags
      (and probably others) cannot work here.
    ; TOFIX: 'ld: library not found for -lharbour' is still
             present.

It's possible that it cannot accept during linking harbour shared
library which is not located in one of system directories.
But 1-st I would like to see file list inside final .tgz archive.
I'll commit some modifications to hb-mkslib.sh in a while and
if possible please rebuild Harbour and send this list to me.

Sure.

  * include/hbsetup.h
    + Added autodetection for HB_OS_DARWIN (based on __APPLE__).

If possible please try to extend this condition adding some additional
macro like __unix__, f.e.:
  #if defined(__APPLE__) && \
      ( defined(unix) || defined(__unix) || defined(__unix__) )
     #define HB_OS_DARWIN
  #endif

to avoid possible collision with some older MacOS versions.

Okay, I'll commit this.

  * source/vm/runner.c
      __HRBGETFU  -> HB_HRBGETSYMBOL

This functions should be renamed to HB_HRBGETFUN[C[SYM]]()
and fixed to respect only functions. Now it can return memvar or alias
symbol if it exists with the same name as function in .hrb file.

      __HRBDOFU   -> HB_HRBDOSYMBOL

This functions is redundant and should be removed. It's subset of
DO() function functionality.

I'll commit both.

    ; NOTE: HB_DBG_*() function should I believe correctly
            named as __DBG*(), as they are indeed internal
            functions, not meant to guaranteed for final apps.
            We should do this cleanup in the future.

No one should try to access debugger functions in normal code
because we do not guarantee that we will keep their functionality
in the future so they should rather use __DBG*() prefix anyhow
the debugger code is mostly developed by Phil Krylov in xHarbour
and such modification will make synchronization with xHarbour harder.

Yes, plus we already have some wrappers for even older (__VM*())
functions once renamed to HB_DBG_*(). We should clean this up
later also IMO. It's not a big task whatsoever.

Brgds,
Viktor

_______________________________________________
Harbour mailing list
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour