Hi Przemek,

 * harbour/contrib/hbcurl/hbcurl.c
   + use hash table to keep strings passed to CURL library accessible
     even if HVM destroys them. It should allow to safely use HBCURL
     wrapper also with CURL library older then 7.17.0 though it can
     be a little bit expensive in some cases. The allocated strings
     are freed when CURL pointer is destroyed (directly or by
     CURL_EASY_CLEANUP()) or reset by CURL_EASY_RESET().
     This feature is enabled only when compiled for CURL libraries
     older then 7.17.0 or when user set explicitly compile time macro
     HB_CURL_HASH_STRINGS
     Viktor, you are more familiar with this code so please check it.

Many thanks, it looks good to me, except a few minor past an
new things:

1) Re-reading the docs now, it seems that there is at least one place
where your new method to cache strings is needed regardless of libcurl
version: curl_formadd() with CURLFORM_COPYNAME. The docs says we should
copy the string. So this might have been a pending bug in hbcurl.

2) curl_slist_append() does copy the string, so we don't need to deal
with it, at least as per the latest docs on the website.

Brgds,
Viktor

_______________________________________________
Harbour mailing list
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour

Reply via email to