---------- Forwarded message ---------
From: Anthony Doeraene <anthony.doeraene....@gmail.com>
Date: Mon, Aug 26, 2024 at 11:14 AM
Subject: Re: [PATCH 1/2] FEATURE: add MPTCP per address support
To: Willy Tarreau <w...@1wt.eu>
Hello,
On Fri, Aug 23, 2024 at 4:36 PM Willy Tarreau <w...@1wt.eu> wrote:
> > diff --git a/include/haproxy/compat.h b/include/haproxy/compat.h
> > index 3829060b7..2347d62cb 100644
> > --- a/include/haproxy/compat.h
> > +++ b/include/haproxy/compat.h
> > @@ -317,6 +317,11 @@ typedef struct { } empty_t;
> > #define queue _queue
> > #endif
> >
> > +/* only Linux defines IPPROTO_MPTCP */
> > +#ifndef IPPROTO_MPTCP
> > +#define IPPROTO_MPTCP 262
> > +#endif
>
> Stupid open question: do we really want to define it for other
> OSes ? I really don't care, to be honest.
It simplifies a lot the code, by not having to put nasty #ifdef IPPROTO_MPTCP
everywhere, that would make quickly the code unreadable. However, we made
sure that it isn't possible to create sockets with IPPROTO_MPTCP, to avoid
users having some difficult to understand error because the protocol isn't
supported on their platform
Thank you for your quick feedback ! A second version of these patches should
soon follow, I'm only adjusting the last details.
Have a nice day,
Doeraene Anthony
