On 12/14/22 21:23, Илья Шипицин wrote:
Can you try to bisect?

I had made some incorrect assumptions about what's needed to use bisect. With a little bit of research I figured it out and it was a LOT easier than I had imagined.

I suspect that it won't help, browsers tend to remember things in their own way

One thing I have learned in my testing is that doing shift-reload on the page means it will never switch to h3. So I use shift-reload followed by a couple of regular reloads as a way of resetting what the browser remembers. That seems to work.

The bisect process only took a few runs to find the problem commit:

3ca4223c5e1f18a19dc93b0b09ffdbd295554d46 is the first bad commit
commit 3ca4223c5e1f18a19dc93b0b09ffdbd295554d46
Author: Amaury Denoyelle <adenoye...@haproxy.com>
Date:   Wed Dec 7 14:31:42 2022 +0100

    BUG/MEDIUM: h3: reject request with invalid header name

    Reject request containing invalid header name. This concerns every
    header containing uppercase letter or a non HTTP token such as a space.

    For the moment, this kind of errors triggers a connection close. In the
    future, it should be handled only with a stream reset. To reduce
    backport surface, this will be implemented in another commit.

    Thanks to Yuki Mogi from FFRI Security, Inc. for having reported this.

    This must be backported up to 2.6.

    (cherry picked from commit d6fb7a0e0f3a79afa1f4b6fc7b62053c3955dc4a)
    Signed-off-by: Christopher Faulet <cfau...@haproxy.com>

 src/h3.c | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

Reply via email to