I have tested that patch and it seems to work. https://www.easypost.com is now returning the correct headers over HTTP/2.
Thanks for the quick turnaround! On Mon, Nov 19, 2018 at 7:54 PM Willy Tarreau <[email protected]> wrote: > On Mon, Nov 19, 2018 at 11:55:04PM +0100, Willy Tarreau wrote: > > > I assume this is a bug in the HPACK encoder, given that in the static > > > table definition [1], accept-language has index 17, while > > > accept-ranges has 18, which is correctly documented in > > > src/hpack-tbl.c, but the comment on line 105 in src/hpack-enc.c makes > > > me doubt our implementation: > > > > > > out->str[len++] = 0x51; // literal with indexing -- > > > name="accept-ranges" (idx 17) > > > > > > > > > Too much string magic going on there for me to provide prompt > > > solution, but I assume this will be a quick fix for Willy. > > > > Gloups! I'm quite ashamed, totally ashamed, almost red. I'll take a > > look at this tomorrow. Thanks for the report! > > I've just pushed the fix. I'm attaching the backported version for your > convenience (as it will not apply as-is to 1.8). > > Thanks! > Willy > -- James Brown Engineer
