Hi James,

On Mon, 19 Nov 2018 at 19:29, James Brown <[email protected]> wrote:
>
> Here's a strange thing I've noticed:
>
> When using HTTP/2, HAproxy is rewriting the "Accept-Ranges" response header 
> into "Accept-Language".

Yup, exactly as you described, thanks for the report.

I assume this is a bug in the HPACK encoder, given that in the static
table definition [1], accept-language has index 17, while
accept-ranges has 18, which is correctly documented in
src/hpack-tbl.c, but the comment on line 105 in src/hpack-enc.c makes
me doubt our implementation:

out->str[len++] = 0x51; // literal with indexing --
name="accept-ranges" (idx 17)


Too much string magic going on there for me to provide prompt
solution, but I assume this will be a quick fix for Willy.

This bug is in there since the HPACK encoder was introduced in 1.8-rc1.



cheers,
lukas

[1] https://tools.ietf.org/html/rfc7541#appendix-A

Reply via email to