On Thu,  1 Dec 2016 22:50:20 -0800
Michael Forney <[email protected]> wrote:

Hey Michael,

> memmove moves a number of bytes, not pointers, so if you passed a
> number of arguments that is larger than the pointer byte size, you
> could end up crashing or skipping the install of a file and
> installing another twice.
> 
> Also, argv was never decreased to match the moved arguments, so the -t
> parameter was added in the NULL argv slot.

after taking another look at this patch, it totally makes sense. Thanks
for your submission! I applied it, but need to note here that this is a
pretty hacky contraption. :P

Cheers

Laslo

-- 
Laslo Hunhold <[email protected]>

Reply via email to