Hi,

"Jodi Jodington (dev)" <[email protected]> writes:

[...]

>> The problem reported here, IIUC, is that it can leave a broken hook in
>> the Guix repo when the user ran it before running 'make', which appears
>> to match the documented recommendations from (info "(guix) Building
>> from
>> Git"), added in commit 73b3f941d7d911a1b2bb2bf77d37cb3a12ed4291
>> ("maint:
>> Suggest ‘guix git authenticate’ for initial authentication.").

> This is what I was encountering, yes.

>> I see two ways to fix this:
>>
>> 1. 'guix git authenticate' smarter not install its own hooks when
>> working from a Guix checkout (by checking the git remote, for
>> example).

> I dont think this would be possible for forks as their remote wont
> match the official git repo. And in general, its probably not a good
> idea to use any complicated heuristics for this. A --no-hook option as
> Ludovic suggested would be a good way forward in my opinion.

How about option 2 then? It'd be a rather simple and effective means to ensuring
the right hook is in use when working from a Guix checkout.

A '--no-hook' option seems of little value to me at least to fix the
issue at hand, as it would rely on users knowing to use such option it
the first place, and in which context.

-- 
Thanks,
Maxim

Reply via email to