Hi Jodi, "Jodi Jodington (dev)" <[email protected]> skribis:
> It was quite discouraging to me that following the official > instructions wasn't enough to contribute to guix. > It would be nice if the manual warned you that if you were doing this > with a fork, you should look at > the `Invoking Guix Authenticate` chapter of the guix manual to see how > to add your GPG key > as a valid signature for your branch (or suggest deleting the pre-push > hook if you don't care). I agree, it’s poor experience when the official instructions do not match reality. Would you like to create a pull request fixing it, or at least an issue so we don’t lose track of it? > I also think that `guix git authenticate` creating a git hook without > any prompting or explicit arguments is pretty invasive behavior in > general and > doesn't really justify itself. I would prefer it if you had to do > something like > `guix git authenticate --add-hook` or similar (or just have users > create the hook themselves, it isnt a big deal imo) ‘guix git authenticate’ prints a message when it installs hooks. The choice to install those hooks by default was made a while back and the rationale was that, generally speaking, the goal of the tool is to authenticate your Git checkout and doing it automatically is the only sensible way to avoid mistakes. But as you point out, that’s not a good default for someone willing to work on a fork. Perhaps we could keep the default unchanged and add a ‘--no-hooks’ option? Thanks, Ludo’.
