Hi, Ludovic Courtès <l...@gnu.org> writes:
> Hello, > > Andreas Enge <andr...@enge.fr> writes: > >> I have recently been surprised by committers approving pull requests, >> wondering why they did not instead push them themselves. > > I occasionally do this to express approval right away when I know I > won’t be able to push it before some time (for instance because my work > tree is dirty, or because I’d rather avoid switching contexts). > > (This is a situation where people using unauthenticated repos would > click the “Merge” button.) Same. >> So how should we proceed? >> You probably guess from the above that I think that committers should >> not approve, but commit instead. >> And when I think about it, committers should also push (and sign) other >> committers' PRs. > > I think any committer should feel entitled to push approved commits, > generally speaking. > > Thoughts? One reason I've been approving more than merging recently is simply because I haven't yet taken the time to get comfortable with the new Codeberg flow. It doesn't seem particularly hard, but it's different :-) -- Thanks, Maxim
