Hello, another question of policy and convention.
I have recently been surprised by committers approving pull requests, wondering why they did not instead push them themselves. It might make sense when reacting to other committers (we never discussed whether it would be more polite to let committers push their own commits, or okay to push on their behalf), but it feels counterproductive with non-committers. When I recently came across such a PR, I ended up spending time looking at it again - having someone else approve it gave me confidence and I was probably a bit faster, but since I was taking responsibility by being the one signing the commit, I also did not want to push it blindly. So instead of just one committer spending time on this PR, we ended up being two. So how should we proceed? You probably guess from the above that I think that committers should not approve, but commit instead. And when I think about it, committers should also push (and sign) other committers' PRs. What do you think? Andreas
