Ludovic Courtès <l...@gnu.org> writes: > Hello, > > Hilton Chain <hako@ultrarare.space> writes: > >>> Could you add a user-reviewed tag, color #006400 (same as qa’s >>> reviewed-looks-good)? > > Since team members can review and formally approve pull requests (when > doing a review from the web UI at least, one can click on “approve”; > ‘fj.el’ doesn’t support it yet it seems), is it necessary to add a label > for this? >
Hi, Anyone can approve, even outside of a team, however the approval is not counted, so it only shows in the message history. That means it doesn’t make the patch stand out as I would hope. >>> The only issue I see with this is that non-committers can’t set tags, so >>> it would have to be done like your team tags script, or permissions to >>> set tags should be given to non-committers who ask for it. >> >> Not sure if we can add guix/guix to all teams. Teams currently are set >> with write access to issues and pull requests to their repositories. >> Doing so would be better if possible, since on Debbugs this is open to >> anyone. > > I’m not sure what you mean Hilton; AIUI, team members can add or remove > labels on pull requests, can’t they? > I can’t do it. As I understand it, giving permissions to do labels but not commits can only be done per-account on the repository. Have a nice day, Noé
signature.asc
Description: PGP signature
