Hi Tobias! > The bad things. All of them. In order.
Oh! How are you doing now? Let me know if you need anything. I can try and help in any way plausible. :-) > You did fine, only renaming ‘truetype’ -> ‘ttf’ should have been > separate. If it had been, I don't think it would have been merged. That change has been discussed during review and was only merged after I gave the fact of about fontconfig. :-) > Also omitting it from the change log feels... sneaky, while I'm sure > that wasn't your intention. I understand. I should have mentioned in the log. But it was not sneaky. As mentioned above, it was discussed during review. ;-) But yeah, I should add that to my workflow of making comments/logs. > Anyway: since ‘share/fonts/ttf’ makes font-gnu-freefont inconsistent > with our other fonts[0] for little reason I'd like to revert it back to > ‘truetype’ & change ‘share/fonts/otf’ to ‘opentype’ as well. What do > you think? > > (Not sure what to do with ‘woff’ so I won't touch it.) Agreed! I do not like inconsistencies either. Please find the patch attached with this email. >> But anyway, before merging I well-tested the patch. It does not affect >> anything. > > I know :-) Fontconfig doesn't care about the subdirectory names, it > just scans them all. The names are for humans. All the more reason not > to abbreviate them IMO. Makes sense. Regards, RG.
From 6f709f5dcdb452df365a2f6927c761fc386c0b0e Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgurura...@disroot.org>
Date: Sun, 10 May 2020 23:57:23 -0400
Subject: [PATCH] gnu: font-gnu-freefont: Correct fonts' sub-directory names.
* gnu/packages/fonts.scm (font-gnu-freefont): Fix /share/fonts/*.
[arguments]<#:phases>: Change sub-dir strings from ttf, otf and woff;
to truetype, opentype and webopen; respectively.
---
gnu/packages/fonts.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 6e9b080299..8924c377c6 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -255,11 +255,11 @@ The Lato 2.010 family supports more than 100 Latin-based languages, over
(let ((doc-dir (string-append %output "/share/doc/"
,name "-" ,version))
(ttf-font-dir (string-append %output
- "/share/fonts/ttf"))
+ "/share/fonts/truetype"))
(otf-font-dir (string-append %output
- "/share/fonts/otf"))
+ "/share/fonts/opentype"))
(woff-font-dir (string-append %output
- "/share/fonts/woff")))
+ "/share/fonts/webopen")))
(mkdir-p doc-dir)
(substitute* "Makefile"
(("\\$\\(TMPDIR\\)") doc-dir)
--
2.26.2
0xAE6EF3046D6F7B57.asc
Description: application/pgp-keys
signature.asc
Description: OpenPGP digital signature
