On Sat, Nov 26, 2016 at 07:37:15PM +0100, Ludovic Court??s wrote:
John Darrington <j...@gnu.org> skribis:
> * gnu/build/file-systems.scm (mount-file-system): Append target addr=
when
> mounting nfs filesystems.
Looks like you forgot to address some of suggestions I made
(???string-prefix????,
Ok. I will make that change.
???match???,
Have another look: + (let* ((host (match (string-split source #\:) ((h _)
h)))
and left a question unanswered (port number?):
Sorry. The answer is, no so far as I'm aware, there is no convention which
allows a port number to be specifed in the source field.
, etc)
The only other thing I think you mentioned was using "if" instead of "cond".
I can envisage that in the future there will be a need for other cases, -
it's not just an either/or choice - so it seemed to me that cond was more
appropriate.
I am aware there is room for improvement in this patch (for example in the
case of IP6 addresses?) - any help will be gratefully accepted.
J'
--
Avoid eavesdropping. Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.
signature.asc
Description: Digital signature
