Re: [PATCH 2/2] gnu: python: Add i3-quickswitch.

[Brendan Tildesley]

Leo Famulari 於 2016-09-16 15:46 寫道:
> On Wed, Sep 14, 2016 at 11:17:24AM +0200, Ivan Vilata i Balaguer wrote:
>> Subject: [PATCH 2/2] gnu: python: Add i3-quickswitch.
>>
>> * gnu/packages/python.scm (i3-quickswitch): New variable.
> Cool, this works :)
>
>> +(define-public i3-quickswitch
>> +  (package
>> +    (name "i3-quickswitch")
> Again, I think that we should stay closer to the upstream name, in this
> case "quickswitch-for-i3".
I'm not a fan of "quickswitch-for-i3" and "python-i3-py". Perhaps a
better solution is to ensure "i3-py" in the description or synopsis so
that `guix package -s' finds it. As for quickswitch, isn't the upstream
name also simply "quickswitch-i3"?
>> +    (build-system python-build-system)
> Also again, it would be nice to include README.rst.