On Tue, Aug 30, 2016 at 03:43:05PM +0100, Marius Bakke wrote: > Shogun failed to build in this run. I don't have time to investigate > further, so picking the OpenBLAS update is not very appealing. > > Instead I opted to disable the test that fails with lapack (and without, > on Hydra), since it's one specific openblas operation that is not unique > to dlib. I think it's an acceptable tradeoff, to give users the full > dlib functionality, and have the segfault "sort itself" when > core-updates lands in master.
Okay, this sounds fine to me. > Below is a patch which disables these tests (and the above segfault) for > 19.1, rather than backporting the patches from dlib master branch. > > One note about the patch: I could not figure out how to pass the list of > tests as arguments to `substitute*`, so currently it calls `substitute*` > for each of them. Any tips to prevent this? Not from me — Calling all seasoned Schemers to thread :) If nobody replies I will say this solution is fine. Changing the subject, you could disable the tests per-architecture. Look for uses of current-target-system and current-system for usage examples. But this is not absolutely required, IMO. > It also no longer builds the main application twice for tests. Thank you :)
