On Sat, Aug 13, 2016 at 07:48:36PM +0100, Marius Bakke wrote:
> Note that it bundles googletest; I tried unbundling but it proved
> difficult. gtest will no longer be used from the 0.6 release so I did
> not think a comment was necessary.
I am cc-ing Lukas with my reply, since he added our googletest package.
Maybe he has some insight.
> * gnu/packages/capnproto.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
How about putting it in serialization.scm? There is protobuf.scm, but
that predates the serialization module.
> + (snippet
> + ;; Workaround for test that tries to resolve port name from
> + ;; /etc/services, which is not present in build environment.
> + '(substitute* "src/kj/async-io-test.c++" ((":http") ":80")))))
Origin snippets affect the result of `guix build --source`, and I think
their use should be limited to fixing critical bugs or software freedom
problems. This is working around a peculiarity of our build system, so I
think we should do it in a build phase, with modify-phases.
Can you send an updated patch?
Otherwise it looks good. Let's wait a couple days to see if anyone has
any advice about googletest.
