On Jun 28, 2015 10:38 PM, "Ludovic Courtès" <l...@gnu.org> wrote:
> "Claes Wallin (韋嘉誠)" <g...@clacke.user.lysator.liu.se> skribis:
> > + (search-paths
> > + (list (search-path-specification
> > + (variable "CPATH")
> > + (files '("include")))
> > + (search-path-specification
> > + (variable "LIBRARY_PATH")
> > + (files '("lib")))))
>
> This is not needed here (‘gcc’ handles that.)
Huh. It seemed to fix something for me, but must be something else I
changed then.
But that probably explains something else. I'm working on s6, and it
expects -lexecline to work. Currently I'm feeding its configure
"--with-lib=.../lib/execline", would be nice to get that done in
execline instead. Modifying LIBRARY_PATH has no effect, what do I need
to do to override gcc?
> > + (synopsis "Common libraries for skarnet.org software")
> > + (description
> > + "General-purpose libraries for minimalist C development, used by all
> > + skarnet.org software.")
> ^^^^^^
> Please remove extra space here.
>
> Also, what about something like:
>
> This package provides lightweight C libraries for <list examples of
> features, like data structures and such>. They are used by
> skarnet.org software.
I'll look into it.
> > * gnu/package/skarnet.scm (execline): New variable.
> ^
> Extra space.
Oops.
> > diff --git a/gnu/packages/patches/execline-fix-gen-deps.patch
> > b/gnu/packages/patches/execline-fix-gen-deps.patch
> > new file mode 100644
> > index 0000000..79bdc95
> > --- /dev/null
> > +++ b/gnu/packages/patches/execline-fix-gen-deps.patch
> > @@ -0,0 +1,12 @@
>
> Please start the .patch with a brief description of what it does, and
> its upstream status (like “Upstream commit XYZ”, or “Submitted upstream
> at http://...”.)
Ok. I'll rename it too, as s6 turned out to need the same patch as
well. It's not guix-specific, they actually don't compile from source.
It's funny.
> > + #:modules ((guix build utils)
> > + (guix build gnu-build-system)
> > + (ice-9 popen))
>
> Replace the first two with:
>
> ,@%gnu-build-system-modules
Aha, cool.
> and use a backquote instead of a quote in ‘arguments.’
Yeah, of course.
> > + "Execline is a (non-interactive) scripting language, like sh, but its
> > +syntax is quite different from a traditional shell syntax. The execlineb
> > +program is used strictly as a parser for a text file and generates a single
> > +command execution with the entire script stored in the argument array.
> > +The language is a library of binaries useful for the tail call or
> > +chain execution style that the parser requires.
> > +
> > +It is as powerful as a shell: It features conditional loops,
> > +getopt-style option handling, filename globbing, and more. Meanwhile, its
> > +syntax is unambiguous and simple, allowing a minimal parser, which doesn't
> > +even stay in memory when parsing is done and execution starts.")))
>
> s/filename/file name/
> It would be nice to make it a couple of lines shorter.
Yeah. I'll spend some more effort on removing what can be removed.
> > * gnu/package/skarnet.scm (execline): wrap execlineb to have its own
> > .../bin first in PATH
>
> LGTM, but please merge it with the previous patch.
Ok.
> Could you send updated patches?
Will do!
> Thank you!
Thank *you*!
--
/c
