On Tue, Jun 23, 2015 at 1:43 PM, Alex Kost <alez...@gmail.com> wrote:
> --8<---------------cut here---------------start------------->8--- > gnu: Add pv. > > * gnu/package/pv.scm (pv): New file. > * gnu-system.am (GNU_SYSTEM_MODULES): Add it. > --8<---------------cut here---------------end--------------->8--- > > And you also need to add "gnu/package/pv.scm" to "gnu-system.am". See > commit 741115b for example. > IIUC you are the only author of this file, right? Then there is no > place for Ludovic there. > I think we prefer 'define-public' over exporting the package variables, > but it is probably not a strong convention. > I would put "Pipe Viewer" in parentheses: > > "pv (Pipe Viewer) is a terminal-based tool for monitoring the progress > I realize that you took this description from the home page, but our > convention is to use two spaces between sentences. Updated accordingly! -- /c
0001-gnu-Add-pv.patch
Description: Binary data
