Claes Wallin (韋嘉誠) (2015-06-19 21:51 +0300) wrote: > From 9213e7207f5e72bf66460d2cdf4e27a86609e322 Mon Sep 17 00:00:00 2001 > From: Claes Wallin <claes.wal...@greatsinodevelopment.com> > Date: Fri, 19 Jun 2015 20:12:09 +0200 > Subject: [PATCH] gnu/package/pv.scm (pv): New file, new variable > > Signed-off-by: Claes Wallin <claes.wal...@greatsinodevelopment.com>
I think there is no need in this ↑ line. The commit message should be: --8<---------------cut here---------------start------------->8--- gnu: Add pv. * gnu/package/pv.scm (pv): New file. * gnu-system.am (GNU_SYSTEM_MODULES): Add it. --8<---------------cut here---------------end--------------->8--- And you also need to add "gnu/package/pv.scm" to "gnu-system.am". See commit 741115b for example. > --- > gnu/packages/pv.scm | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 gnu/packages/pv.scm > > diff --git a/gnu/packages/pv.scm b/gnu/packages/pv.scm > new file mode 100644 > index 0000000..f0eac85 > --- /dev/null > +++ b/gnu/packages/pv.scm > @@ -0,0 +1,48 @@ > +;;; GNU Guix --- Functional package management for GNU > +;;; Copyright 2012, 2013, 2015 Ludovic Courts <l...@gnu.org> > +;;; Copyright 2015 Claes Wallin <claes.wal...@greatsinodevelopment.com> IIUC you are the only author of this file, right? Then there is no place for Ludovic there. > +;;; > +;;; This file is part of GNU Guix. > +;;; > +;;; GNU Guix is free software; you can redistribute it and/or modify it > +;;; under the terms of the GNU General Public License as published by > +;;; the Free Software Foundation; either version 3 of the License, or (at > +;;; your option) any later version. > +;;; > +;;; GNU Guix is distributed in the hope that it will be useful, but > +;;; WITHOUT ANY WARRANTY; without even the implied warranty of > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +;;; GNU General Public License for more details. > +;;; > +;;; You should have received a copy of the GNU General Public License > +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>. > + > +(define-module (gnu packages pv) > + #:use-module (guix licenses) > + #:use-module (guix packages) > + #:use-module (guix download) > + #:use-module (guix build-system gnu) > + #:export (pv)) > + > +(define pv I think we prefer 'define-public' over exporting the package variables, but it is probably not a strong convention. > + (package > + (name "pv") > + (version "1.6.0") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "http://www.ivarch.com/programs/sources/pv-"; > + version ".tar.bz2")) > + (sha256 > + (base32 > + "13gg6r84pkvznpd1l11qw1jw9yna40gkgpni256khyx21m785khf")))) > + (build-system gnu-build-system) > + (home-page "http://www.ivarch.com/programs/pv.shtml";) > + (synopsis "Pipeline progress indicator") > + (description > + "pv - Pipe Viewer - is a terminal-based tool for monitoring the progress I would put "Pipe Viewer" in parentheses: "pv (Pipe Viewer) is a terminal-based tool for monitoring the progress but I think you may ignore this comment. > +of data through a pipeline. It can be inserted into any normal pipeline of data through a pipeline. It can be inserted into any normal pipeline I realize that you took this description from the home page, but our convention is to use two spaces between sentences. > +between two processes to give a visual indication of how quickly data is > +passing through, how long it has taken, how near to completion it is, and an > +estimate of how long it will be until completion.") > + (license artistic2.0))) -- Alex
