Thanks for the review.
On Thu, Jun 18, 2015 at 8:45 AM, Ricardo Wurmus <rek...@elephly.net> wrote:
>
> David Hashe <david.ha...@dhashe.com> writes:
>
> > * gnu/packages/gnome.scm (rhythmbox): New variable.
>
> [...]
>
> > +(define-public rhythmbox
> > + (package
> > + (name "rhythmbox")
> > + (version "3.2.1")
> > + (source (origin
> > + (method url-fetch)
> > + (uri (string-append "mirror://gnome/sources/rhythmbox/3.2/"
>
> Can you use (version-major+minor version) instead of “3.2” here?
>
>
I also replaced each instance of "rhythmbox" with name.
> > + "rhythmbox-" version ".tar.xz"))
> > + (sha256
> > + (base32
> > + "0f3radhlji7rxl760yl2vm49fvfslympxrpm8497acbmbd7wlhxz"))))
> > + (build-system glib-or-gtk-build-system)
> > + (native-inputs
> > + `(("intltool" ,intltool)
> > + ("glib" ,glib "bin")
> > + ("gobject-introspection" ,gobject-introspection)
> > + ("pkg-config" ,pkg-config)))
>
> The indentation of (native-inputs ...) is wrong.
>
> + (inputs
> > + `(("json-glib" ,json-glib)
>
> [...]
>
> > + ("brasero" ,brasero)))
>
> Is Brasero an optional input? It’s a CD burning application, which
> seems unrelated to a music player. Will Totem work even if Brasero is
> not available at build time? Or does it integrate more deeply with
> Brasero?
>
>
It's an optional input. Rhythmbox uses it (specifically libbrasero-media)
to allow burning playlists straight to CD.
Your comment also made me realize that I had the home-page wrong; I've
fixed that.
> > + (description "Rhythmbox is a music playing application for GNOME. It
> supports
> > +playlists, song ratings, and any codecs installed through
> > gstreamer.")
>
> Please use two spaces at the end of a sentence.
>
> ~~ Ricardo
>
>
Updated patch attached.
David
From eda2e8e75c0f21dae5ebfec1a2376830d8104d71 Mon Sep 17 00:00:00 2001
From: David Hashe <david.ha...@dhashe.com>
Date: Wed, 17 Jun 2015 23:59:11 -0500
Subject: [PATCH] gnu: Add rhythmbox.
* gnu/packages/gnome.scm (rhythmbox): New variable.
---
gnu/packages/gnome.scm | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 49 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 4af1d13..ee2bf47 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -2444,3 +2444,52 @@ which are easy to play with the aid of a mouse.")
natively with GTK-Doc (the API reference system developed for GTK+ and used
throughout GNOME for API documentation).")
(license license:gpl2+)))
+
+(define-public rhythmbox
+ (package
+ (name "rhythmbox")
+ (version "3.2.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/" name "/"
+ (version-major+minor version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "0f3radhlji7rxl760yl2vm49fvfslympxrpm8497acbmbd7wlhxz"))))
+ (build-system glib-or-gtk-build-system)
+ (native-inputs
+ `(("intltool" ,intltool)
+ ("glib" ,glib "bin")
+ ("gobject-introspection" ,gobject-introspection)
+ ("pkg-config" ,pkg-config)))
+ (inputs
+ `(("json-glib" ,json-glib)
+ ("libpeas" ,libpeas)
+ ("tdb" ,tdb)
+ ("totem-pl-parser" ,totem-pl-parser)
+ ("webkitgtk" ,webkitgtk)
+ ("gnome-desktop" ,gnome-desktop)
+ ("python" ,python)
+ ("gmime" ,gmime)
+ ("nettle" ,nettle)
+ ("itstool" ,itstool)
+ ("adwaita-icon-theme" ,adwaita-icon-theme)
+ ("gst-plugins-base" ,gst-plugins-base)
+ ("gst-plugins-good" ,gst-plugins-good)
+ ("gstreamer" ,gstreamer)
+ ("gudev" ,eudev)
+ ("libmtp" ,libmtp)
+ ("libsecret" ,libsecret)
+ ("libnotify" ,libnotify)
+ ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+ ("atk" ,atk)
+ ("pango" ,pango)
+ ("desktop-file-utils" ,desktop-file-utils)
+ ("brasero" ,brasero)))
+ (home-page "https://wiki.gnome.org/Apps/Rhythmbox";)
+ (synopsis "Music player for GNOME")
+ (description "Rhythmbox is a music playing application for GNOME. It
+supports playlists, song ratings, and any codecs installed through gstreamer.")
+ (license license:gpl2+)))
+
--
1.9.1
