Taylan Ulrich Kammer writes:
> Christopher Allan Webber <cweb...@dustycloud.org> writes:
>
>> Okay, how about a version of guile-emacs that works and incorporates
>> feedback from this thread? Yeah? Anyone?
>>
>> Whoooooooooo guile-emacs! :)
>
> Yay! :-)
>
> I would have thought these would go to guile.scm and emacs.scm. What do
> others think?
It can be done... since guile-for-guile-emacs doesn't make sense without
guile-emacs (probably), I thought maybe bundling them together makes
sense...
>> +(define-public guile-for-guile-emacs
>> [...]
>> + (inputs
>> + `(("gettext" ,gnu-gettext)
>
> Sure it shouldn't be in native-inputs? I'm guessing autogen uses it.
So, could someone describe the difference between inputs and
native-inputs? The manual provides no clarity! I never know where it
goes and why... I just mime what other packages are doing.
>> +(define-public guile-emacs
>> [...]
>> + (substitute-keyword-arguments `(#:parallel-build? #f
>
> A comment explaining why parallel builds are disabled would be good.
Good idea.
>> + ;; Tests aren't passing for now.
>> + ;; Obviously we should re-enable this!
>> + #:tests? #f
>
> Tests should generally always be enabled so the second line of the
> comment would be redundant; just a nitpick. :-)
Yes, but this time especially! I think it'll be a good sign for
guile-emacs when we can tear off the test disabling... :)
>
> Otherwise looks good to me. Thanks!
>
> Taylan
