Axel <gra...@gmail.com> skribis: > Well, I modified the patch and now it just trivially add paths for > fish, tcsh and zsh. > > For example Debian has add-shell/remove-shell scripts triggered on > package installing and removing. FTP servers like proftpd by default > check for installed shells and with this patch they will allow for a > user shells that don't really exist in a system. Probably it is not a > problem though.
I think it’s fine. > I noted in a changelog what we add paths unconditionally. I moved this explanation as a comment in the code itself; we only mention in change logs the actual changes, and explanations usually go to comments (info "(standards) Change Logs"). > From d17569a3b3f00066531361b9f29b840be2444982 Mon Sep 17 00:00:00 2001 > From: "Alexander I.Grafov (Axel)" <gra...@gmail.com> > Date: Wed, 11 Mar 2015 15:17:24 +0300 > Subject: [PATCH] system: Add fish/tcsh/zsh to /etc/shells > > * gnu/system.scm (etc-directory): Add fish, tcsh and zsh paths > to /etc/shells. We don't check that these shells really installed. Applied, thanks! Ludo’.
