On Sun, Dec 14, 2014 at 11:54 PM, Ludovic Courtès <l...@gnu.org> wrote:
> Federico Beffa <be...@fbengineering.ch> skribis:
>
>> + (alist-cons-before
>> + 'check 'fix-failing-tests
>> + (lambda _
>> + (substitute* (find-files "numpy/linalg/tests"
>> + "test_regression\\.py")
>> + (("x = np.eye(1000, 66)")
>> + "x = np.eye(10, 66)")))
>
> Could you add a comment here explaining that this is reducing the input
> matrix size (?) and why it matters? Otherwise it may seem a bit too
> magical. :-)
>
> Also, this kind of change would be a good candidate for ‘snippet’,
> because it’s a “static” change.
OK, I need to look into those :-)
Actually the test is still failing and I do not understand why on
hydra it is failing while on my machine (x86_64) it passes with both
python versions. So, at least for the moment, I would propose to
remove the above phase and disable the tests.
WDYT?
Fede
