Federico Beffa <be...@fbengineering.ch> skribis:

> +        (alist-cons-before
> +         'check 'fix-failing-tests
> +         (lambda _
> +           (substitute* (find-files "numpy/linalg/tests" 
> +                                    "test_regression\\.py")
> +             (("x = np.eye(1000, 66)")
> +              "x = np.eye(10, 66)")))

Could you add a comment here explaining that this is reducing the input
matrix size (?) and why it matters?  Otherwise it may seem a bit too
magical.  :-)

Also, this kind of change would be a good candidate for ‘snippet’,
because it’s a “static” change.

Thanks,
Ludo’.

Reply via email to