Andreas Enge <andr...@enge.fr> skribis: > thanks for the patch, and congratulations for your first guix package > (which I did not try out yet, I simply assumed it worked...).
Indeed, cool. :-) And thanks to the other people for the reviews! > Actually, it should go into oggvorbis.scm, where we put all xiph codecs. > Could you please do so and drop the new file, also from gnu-system.am? Agreed. > I am not sure about the > Signed-off-by: Sree Harsha Totakura <sreehar...@totakura.in> > field; normally you are simply the author, no need to add it (and when > Ludovic applies patches coming from the list, he normally signs them off). Right. Note to the reviewers: feel free to push a patch that looks good to you and uncontroversial, per the guidelines in ‘HACKING’. Don’t be shy. ;-) Ludo’.
