Chris Vine <vine35792...@gmail.com> writes: > On Tue, 09 Apr 2019 04:35:38 -0400 > Mark H Weaver <m...@netris.org> wrote: >> >> I think it's probably fine for 2.2, although a more careful check should >> be made for differences in behavior between the old and new >> implementations, and tests should be added. I'll try to get to it soon. > > If it is going in 2.2 (or 3.0) it would be nice if the ports could be > suspendable. put-bytevector (used by write!) is suspendable; > get-bytevector-some (used by read!) is not.
In my previous message, I forgot to mention that I don't believe my patch would introduce a regression here, because the old implementation of 'open-pipe*' in OPEN_BOTH mode _also_ used a kind of custom port implemented in C, namely Guile's old "soft ports". That said, I certainly agree that it would be good to make more I/O operations suspendable, and to make custom ports suspendable as well. Mark