Daniel Hartwig <mand...@gmail.com> writes:
> One final thing before I resubmit. I just notice that most of this
> file has uses hard tabs, though there are places with soft. Is it
> preferable to change the patch to also use hard tabs?
IMO, even when editing code that currently uses hard tabs, all new lines
should use soft tabs, and ideally all *changed* lines should also be
converted to soft tabs. Makefiles are a special case of course.
Hard tabs cause several problems, e.g. messed up indentation in patches,
even if the file uses hard tabs consistently. Personally, I'd like to
work toward a future with no soft tabs, even if it excerbates the messed
up indentation problem in the short term.
What do you think?
Mark
PS: I recommend setting 'indent-tabs-mode' to nil in Emacs.
