Daniel Hartwig <[email protected]> writes:
> On 10 October 2012 01:48, Mark H Weaver <[email protected]> wrote:
>> Please drop the unneeded curly braces above.
>
> Are guile's macros safe to always use that way?
They should be. If they aren't, that's a bug IMO.
> In libguile/__scm.h
> the SCM_ASSERT definition is conditional on SCM_RECKLESS and appears
> unsafe without the block.
Looks safe to me. If SCM_RECKLESS is set, then 'SCM_ASSERT(...)'
becomes the empty string, but the immediately following ';' remains
and becomes a C null statement.
Your latest patch looks good, but I just remembered one more thing:
doc/ref/api-data.texi needs to be updated.
Are you willing? :)
Thanks!
Mark
