Ludovic Courtès escreveu:
>> @@ -472,6 +480,7 @@ scm_i_init_guile (SCM_STACKITEM *base)
>> scm_init_backtrace (); /* Requires fluids */
>> scm_init_fports ();
>> scm_init_strports ();
>> + scm_init_ports ();
>> scm_init_gdbint (); /* Requires strports */
>> scm_init_hash ();
>> scm_init_hashtab ();
>> @@ -490,7 +499,6 @@ scm_i_init_guile (SCM_STACKITEM *base)
>> scm_init_numbers ();
>> scm_init_options ();
>> scm_init_pairs ();
>> - scm_init_ports ();
>
> Why does it need to be moved?
because gdb instantiates a port; I forgot why it used to work
though.
>> - SCM_SETPTAB_ENTRY (port, pt);
>> + SCM_SETPTAB_ENTRY(port, pt);
>
> Please follow GNU style.
I have the impression that GUILE isn't really consistent
[EMAIL PROTECTED] libguile]$ grep '[A-Z](' *c|grep -v define|wc
394 2037 24632
[EMAIL PROTECTED] libguile]$ grep '[a-z](' *c|grep -v define|wc
490 3038 28008
time for a grand search & replace patch?
>> -#ifdef GUILE_DEBUG
>> /* Functions for debugging. */
>
> Why remove the `#ifdef'?
oops.
>
>> --- a/m4/gnulib-cache.m4
>> +++ b/m4/gnulib-cache.m4
>> @@ -23,6 +23,7 @@ gl_MODULES([alloca strcase])
>> gl_AVOID([])
>> gl_SOURCE_BASE([lib])
>> gl_M4_BASE([m4])
>> +gl_PO_BASE([])
>
> This is unrelated.
yes, I know. Too lazy to strip this from the output. But won't apply to CVS.
--
Han-Wen Nienhuys - [EMAIL PROTECTED] - http://www.xs4all.nl/~hanwen
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel
