Hi,

Glenn Washburn wrote:
> > >  if [ -z "$debug" ] && [ "$RET" -eq "$xfail" ]; then

I wrote:
> > If indeed in a successful --xfail test RET must have the value of "$xfail"
> > (i guess 1), then it is concise and sufficient.

> [...] the only acceptable xfail case is for RET=1. If
> RET is greater than 1, that should be considered a hard error (iow a
> failure of the test itself and not the thing being tested).

How about calling the variable "expected_ret" instead of "xfail" ?
This would express in the code that rogue return values are really
intended to prevent deletion of the test data.


Have a nice day

Thomas


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to