On Wed, Jun 12, 2024 at 06:10:12PM +0200, Daniel Kiper wrote: > On Tue, Jun 11, 2024 at 03:10:56PM +0800, Gary Lin via Grub-devel wrote: > > On Fri, Jun 07, 2024 at 04:14:54PM +0200, Daniel Kiper wrote: > > > On Fri, Jun 07, 2024 at 11:07:31AM +0800, Gary Lin wrote: > > > > On Wed, Jun 05, 2024 at 05:18:32PM +0200, Daniel Kiper wrote: > > > > > On Wed, May 15, 2024 at 01:06:55PM +0800, Gary Lin wrote: > > > > > > From: Daniel Axtens <d...@axtens.net> > > > > > > > > > > > > We don't expect to be able to write ASN.1, only read it, > > > > > > so we can disable some code. > > > > > > > > > > > > Do that with #if 0/#endif, rather than deletion. This means > > > > > > that the difference between upstream and grub is smaller, > > > > > > which should make updating libtasn1 easier in the future. > > > > > > > > > > > > With these exclusions we also avoid the need for minmax.h, > > > > > > which is convenient because it means we don't have to > > > > > > import it from gnulib. > > > > > > > > > > This and two following patches should be put in separate files in the > > > > > grub-core/lib/libtasn1-patches directory. The gnulib is good example > > > > > how it should be done. > > > > > > > > > Those patches are added to libtasn1-patches in another patch with the > > > > title "libtasn1: Add the documentation" which mentions how libtasn1 is > > > > updated. > > > > > > OK, then use them as gnulib does. Of course add the patches one by one > > > to the GRUB source code. > > > > > Does it mean that I should use bootstrap to check out libtasn1 and then > > apply the patches? > > No, for time being it is enough to have static libtasn1 with the patches > applied on top of that lib during bootstrap run. > Got it. I'll update bootstrap or autogen.sh to apply the patches.
Gary Lin _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
