Hey Miguel, On Thu, Apr 15, 2021 at 10:58:38AM +0200, Miguel Ángel Arruga Vivas wrote: > Hi, > > Daniel Kiper <dki...@net-space.pl> writes: > > [...] > > Signed-off-by: Miguel Ángel Arruga Vivas <rosen644...@gmail.com> > > > > I can add this for you before committing the patch. > > That'd be great, thank you. > > >> I added a description of the change there too instead of only making > >> the reference to the manual, but certainly I don't know what SOB means > > > > Great! Though I will tweak it a bit before committing. > > Thanks again. I'm not a great writer even on my mother tongue, any > improvement is always welcome. > > [...] > >> I wasn't quite sure about this, as the column count goes high on my > >> Emacs, should I remove some indentation? Perhaps three lines could be > >> another compromise with N_ and rel_info on separate lines as the other > >> code? > > > > Yep. > > Which one of the three options do you mean? In any case, it goes without > saying that I'm thankful to any tweak performed before pushing the patch > to the working branch.
Here [1] is your updated patch. I have checked the translation file once again and spotted one more issue. I fixed it in this [2] patch. I will merge it when I get a review. Then I will rebuild and repost translation file. Daniel [1] http://git.savannah.gnu.org/gitweb/?p=grub.git;a=commit;h=837fe48deb89b31710904de4e9c7dda258490e1c [2] https://lists.gnu.org/archive/html/grub-devel/2021-04/msg00049.html _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
