Hi,
Daniel Kiper <dki...@net-space.pl> writes:
[...]
> Thank you for the report!
You're welcome! Sorry for the delay again, I've been a bit busy.
[...]
> Could you send this patch using "git send-email"?
I hope the updated patch works fine.
I have some doubts regarding this acryonym:
> Could you add your SOB here?
I added a description of the change there too instead of only making
the reference to the manual, but certainly I don't know what SOB means
in this context, sorry. :-(
Regarding the patch:
>> + char rel_info[17]; /* log16 (2^64) = 16, plus nul. */
>
> Please add empty line here and s/nul/NUL/.
I've added the empty line and modified the NUL as requested.
>> + return grub_error (GRUB_ERR_NOT_IMPLEMENTED_YET,
>> + N_("relocation 0x%s"
>> + " is not implemented yet"),
>> + rel_info);
>
> Please merge all these 3 lines into one, i.e:
> N_("relocation 0x%s" is not implemented yet"), rel_info);
I wasn't quite sure about this, as the column count goes high on my
Emacs, should I remove some indentation? Perhaps three lines could be
another compromise with N_ and rel_info on separate lines as the other
code?
> Does this patch fix all PRI* translation issues?
I think all PRI* issues facing up the user are covered; I grep'ed the
code and they seem to be only used for internal messages.
> When I get next version of patch from you I will rebuild and update pot file.
Sorry again for the delay, and thank you very much for your support.
Happy hacking!
Miguel
Miguel Ángel Arruga Vivas (1):
i18n: Format large integers before the translation message.
grub-core/disk/luks2.c | 5 ++++-
grub-core/efiemu/i386/loadcore64.c | 13 +++++++++----
grub-core/kern/arm64/dl.c | 13 +++++++++----
grub-core/kern/ia64/dl.c | 13 +++++++++----
grub-core/kern/riscv/dl.c | 14 ++++++++++----
grub-core/kern/sparc64/dl.c | 12 ++++++++----
grub-core/kern/x86_64/dl.c | 13 +++++++++----
7 files changed, 58 insertions(+), 25 deletions(-)
--
2.30.0
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
