On Thu, Apr 23, 2020 at 12:10:07PM +0300, Anatoly Pugachev wrote: > On Tue, Jul 30, 2019 at 3:10 PM Anatoly Pugachev <mator...@gmail.com> wrote: > > > > On Tue, Jul 30, 2019 at 1:00 PM John Paul Adrian Glaubitz > > <glaub...@physik.fu-berlin.de> wrote: > > > On 7/30/19 10:11 AM, Anatoly Pugachev wrote: > > > > don't run f2fs test on systems with PAGE_SIZE > 4096 bytes. > > > > Since f2fs is not supported on this systems (can't mount f2fs > > > > filesystem). > > > > > > Some spelling fixes and re-phrasing suggestion: > > > > > > > Don't run f2fs tests on systems with PAGE_SIZE > 4096 bytes since f2fs > > > > is not supported on these systems and mounting a f2fs filesystems fails. > > > > > > And: > > > > > > +PAGE_SIZE=$(getconf PAGE_SIZE) > > > +F2FS_BLKSIZE=4096 > > > +if [ $PAGE_SIZE > $F2FS_BLKSIZE ]; then > > > + printf "F2FS not supported on PAGE_SIZE(%d) != %d\n" $PAGE_SIZE > > > $F2FS_BLKSIZE > > > ^^^^ > > > I would write "f2fs" in lower case here for consistency with the rest > > > of the script. > > > > > > + exit 77 > > > +fi > > > > Adrian, > > > > thanks. Attached v2 patch. > > Any chance this could be merged ? Thanks.
Sorry, somehow I have missed your patch. Next time please use "git send-email ..." to send new patch in new thread. Then it will be much easier to spot. I will put all variables expansions into quotes. Just in case. Otherwise Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
