On Tue, Jul 30, 2019 at 1:00 PM John Paul Adrian Glaubitz <glaub...@physik.fu-berlin.de> wrote: > On 7/30/19 10:11 AM, Anatoly Pugachev wrote: > > don't run f2fs test on systems with PAGE_SIZE > 4096 bytes. > > Since f2fs is not supported on this systems (can't mount f2fs filesystem). > > Some spelling fixes and re-phrasing suggestion: > > > Don't run f2fs tests on systems with PAGE_SIZE > 4096 bytes since f2fs > > is not supported on these systems and mounting a f2fs filesystems fails. > > And: > > +PAGE_SIZE=$(getconf PAGE_SIZE) > +F2FS_BLKSIZE=4096 > +if [ $PAGE_SIZE > $F2FS_BLKSIZE ]; then > + printf "F2FS not supported on PAGE_SIZE(%d) != %d\n" $PAGE_SIZE > $F2FS_BLKSIZE > ^^^^ > I would write "f2fs" in lower case here for consistency with the rest of > the script. > > + exit 77 > +fi
Adrian, thanks. Attached v2 patch.
From 120f8edad0b0cb95aa496b2cc1b8b956f8a6e62f Mon Sep 17 00:00:00 2001 From: Anatoly Pugachev <matorola@gmail.com> Date: Tue, 30 Jul 2019 15:02:40 +0300 Subject: [PATCH] Don't run f2fs tests on systems with PAGE_SIZE > 4KB Don't run f2fs tests on systems with PAGE_SIZE > 4096 bytes, since f2fs is not supported on these systems and mounting a f2fs filesystem fails. Signed-off-by: Anatoly Pugachev <matorola@gmail.com> --- tests/f2fs_test.in | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/f2fs_test.in b/tests/f2fs_test.in index 1ea77c826..7e28fcdcb 100644 --- a/tests/f2fs_test.in +++ b/tests/f2fs_test.in @@ -15,5 +15,11 @@ if ! which mkfs.f2fs >/dev/null 2>&1; then exit 77 fi +PAGE_SIZE=$(getconf PAGE_SIZE) +F2FS_BLKSIZE=4096 +if [ $PAGE_SIZE > $F2FS_BLKSIZE ]; then + printf "f2fs not supported on PAGE_SIZE(%d) != %d\n" $PAGE_SIZE $F2FS_BLKSIZE + exit 77 +fi "@builddir@/grub-fs-tester" f2fs -- 2.22.0
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
